Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backstop: gulp_usdc has 100% slippage tolerance #187

Closed
markuspluna opened this issue Jan 17, 2024 · 1 comment · Fixed by #188
Closed

Backstop: gulp_usdc has 100% slippage tolerance #187

markuspluna opened this issue Jan 17, 2024 · 1 comment · Fixed by #188
Assignees
@markuspluna

Comments

@markuspluna
Copy link
Contributor

The gulp_usdc function hardcodes expected LP tokens out to 0 - which allows anyone to fully sandwich all donate_usdc calls resulting in the backstop never getting an LP tokens.

Update this function to correctly calculate LP tokens out with a 5% slippage tolerance
@markuspluna markuspluna self-assigned this Jan 17, 2024
@markuspluna
Copy link
Contributor Author

Will fix by using stored LP token balances to estimate slippage and calculate an appropriate amount out with 5% slippage permitted

@mootz12 mootz12 linked a pull request Jan 21, 2024 that will close this issue
Refactored interest auction to use backstop token donations #188
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markuspluna markuspluna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored interest auction to use backstop token donations blend-capital/blend-contracts
1 participant
@markuspluna