Refactored interest auction to use backstop token donations #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mootz12
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Implementation looks good to me. Changes are pretty minor, only drawback is that liquidators will be filling auctions with backstop tokens, but it's worth it IMO to prevent the gulp_usdc sandwich attack vector.
Leaving as request changes until test updates are complete.
test-suites/src/test_fixture.rs
Outdated
Comment on lines
94
to
97
| let (aqua_id, aqua_client) = create_token(&e, &bombadil, 7, "AQUA"); | ||
| let (test1_id, test1_client) = create_token(&e, &bombadil, 7, "TEST1"); | ||
| let (test2_id, test2_client) = create_token(&e, &bombadil, 7, "TEST2"); | ||
| let (test3_id, test3_client) = create_token(&e, &bombadil, 7, "TEST3"); |
There was a problem hiding this comment.
assuming these were part of exploratory testing?
There was a problem hiding this comment.
bumping this. Can we clean the test fixture up?
- clean
mootz12
requested changes
Jan 21, 2024
Comment on lines
-26
to
30
| let res_asset_address = reserve_list.get_unchecked(i); | ||
| for res_asset_address in assets.iter() { | ||
| // don't store updated reserve data back to ledger. This will occur on the the auction's fill. | ||
| let reserve = pool.load_reserve(e, &res_asset_address, false); |
There was a problem hiding this comment.
Is there a test that verifies invalid reserves throws an error?
There was a problem hiding this comment.
I didn't notice in the test diff.
- Add negative test for set of addresses with an invalid reserve address
test-suites/src/test_fixture.rs
Outdated
Comment on lines
94
to
97
| let (aqua_id, aqua_client) = create_token(&e, &bombadil, 7, "AQUA"); | ||
| let (test1_id, test1_client) = create_token(&e, &bombadil, 7, "TEST1"); | ||
| let (test2_id, test2_client) = create_token(&e, &bombadil, 7, "TEST2"); | ||
| let (test3_id, test3_client) = create_token(&e, &bombadil, 7, "TEST3"); |
There was a problem hiding this comment.
bumping this. Can we clean the test fixture up?
- clean
mootz12
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to fix tests