Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 160 test auction underflow #173

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Issue 160 test auction underflow #173

merged 2 commits into from
Dec 27, 2023

Conversation

markuspluna
Copy link
Contributor

Added a test that ensures filling an auction on the same block it is created (which would result in an underflow) causes a panic

@markuspluna markuspluna requested a review from mootz12 December 21, 2023 20:23
@mootz12 mootz12 changed the base branch from main to futurenet December 21, 2023 21:30
@mootz12 mootz12 changed the base branch from futurenet to main December 21, 2023 21:31
@markuspluna markuspluna mentioned this pull request Dec 21, 2023
Closed
mootz12
mootz12 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@mootz12 mootz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@markuspluna markuspluna merged commit 7c3724e into main Dec 27, 2023
3 checks passed
@markuspluna markuspluna deleted the issue_160_test_auction_underflow branch December 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mootz12 mootz12 mootz12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markuspluna @mootz12