Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payer payee checks #176

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Payer payee checks #176

merged 8 commits into from
Jan 2, 2024

Conversation

mootz12
Copy link
Contributor

@mootz12 mootz12 commented Dec 31, 2023

No description provided.

Copy link
Contributor

@Ryang-21 Ryang-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo in a test case but everything else looks good


#[test]
#[should_panic(expected = "Error(Contract, #1)")]
fn test_execute_deposit_from_self() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should have been the backstop id in the from parameter

mootz12 and others added 3 commits January 2, 2024 12:01
pool: chore: add extra verification to prevent backstop from filling auctions
Fix Incorrect Validation Locations
@mootz12 mootz12 merged commit 78a4864 into main Jan 2, 2024
3 checks passed
@mootz12 mootz12 deleted the payer_payee_checks branch January 2, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLRC-011 and BLRC-012 - Lack of payer/payee sanity checks in execute_deposit and execute_deposit
2 participants