Comet update #214
Merged
Comet update #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ryang-21
commented
Mar 21, 2024
•
Ryang-21
commented
- Updated comet wasm and comet test setup
- Updated comet authorization in backstop claim function
- Waiting on PR fix: set expiration ledger to current sequence number CometDEX/comet-contracts-v1#5
mootz12
requested changes
Mar 22, 2024
pool/src/storage.rs
Outdated
| e.storage() | ||
| .persistent() | ||
| .extend_ttl(&key, LEDGER_THRESHOLD_SHARED, LEDGER_BUMP_SHARED); | ||
| e.storage().persistent().extend_ttl(&key, 0, 0); |
Comment on lines
173
to
+174
| client.set_public_swap(&admin, &true); | ||
| client.finalize(); |
There was a problem hiding this comment.
why was this change necessary?
IIRC finalize had nothing to do with set_public_swap, but this could have changed on comet's end?
There was a problem hiding this comment.
They now check that finalize has not been called when performing pool setup
|
Merging for now as the Comet PR is still being reviewed. It appears likely this will go through, so in the event something changes, we will do a followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.