Create season champion special badges #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ribeirojose
reviewed
Feb 15, 2025
| user_id: user_id | ||
| }) unless dry_run or !can_complete | ||
| user_id: user_id, | ||
| notify: !dry_run |
There was a problem hiding this comment.
interesting. Would love to explore a more general way of running dry runs/running w/o side effects in general
There was a problem hiding this comment.
Yes, I don't like the way this is being done. The problem is that unlocked_by is used to check if any user has unlocked that badge earlier. If the user tries to collect the badge and it can unlock it, I don't want to notify them, but still want to update unlocked_by. Any idea of how doing that? I thought I could call @unlocked_by << user_id if it's a dry_run and don't calling the event, but don't know if this is good
ribeirojose
reviewed
Feb 15, 2025
apps/govquests-api/govquests/gamification/lib/gamification/strategies/season_champion.rb
Outdated
Show resolved
Hide resolved
ribeirojose
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added season_champion badge type strategy, that verifies:
Added seed for season 7 champion of each tier