Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make chats virtualized #330

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

pixelass
Copy link
Member

@pixelass pixelass commented Jun 5, 2024

Motivation

This feature aims to increase the performance in long chats

  • uses react-virtualized to render virtual chat history
  • requires hacking the overflow of react-virtualized
  • requires determinate/fixed heights of images (should in future be delivered by images, is now hardcoded)

Issues closed

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b8c6ca7) 2114 1986 93.95%
Head commit (f8cd014) 2114 (+0) 1986 (+0) 93.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#330) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTM!

@pixelass pixelass merged commit 2f5eb80 into alpha Jun 5, 2024
5 checks passed
@pixelass pixelass deleted the feat/virtualized-assistant-chat branch June 5, 2024 14:27
TimPietrusky pushed a commit that referenced this pull request Jun 5, 2024
# [1.0.0-alpha.99](v1.0.0-alpha.98...v1.0.0-alpha.99) (2024-06-05)

### Features

* make chats virtualized ([#330](#330)) ([2f5eb80](2f5eb80))
@TimPietrusky
Copy link
Member

🎉 This PR is included in version 1.0.0-alpha.99 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants