Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add text wrapping option #299

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

cary-rowen
Copy link
Collaborator

Link to issue number:

N/A

Summary of the issue:

Need to add a configurable text wrapping option in the appearance settings panel.

Description of how this pull request fixes the issue:

  • Added text_wrap boolean config option in spec.py
  • Added checkbox in AppearancePanel for text wrapping control
  • Implemented restart prompt when text wrap setting changes
  • Updated text control to use text wrapping configuration

Testing performed:

  • Verified config saving/loading
  • Tested settings UI interaction
  • Confirmed restart prompt works
  • Validated text wrapping behavior after restart

Known issues with pull request:

  • Requires application restart to take effect
    • The wx.TE_DONTWRAP style flag must be set when creating the TextCtrl
    • This style cannot be changed after the control is created

Implemented text wrapping configuration:
- Added new config option for text wrapping
- Created checkbox in appearance settings panel
- Added logic to handle text wrap setting with restart notification
- Updated text control to respect text wrapping configuration
@pauliyobo
Copy link
Collaborator

Hello.
Thanks for the PR.
Looks good to me.

@pauliyobo pauliyobo merged commit b8d4a87 into blindpandas:develop Feb 6, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants