CONTRIB-9525: Fix error on return of get_role (#616)

blindsidenetworks-ps · Mar 25, 2024 · 123a9af · 123a9af
1 parent 5e9ec5d
commit 123a9af
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/classes/local/helpers/roles.php b/classes/local/helpers/roles.php
@@ -184,9 +184,9 @@ protected static function get_roles_select(context $context = null, bool $onlyvi
      *
      * @param string|integer $id
      *
-     * @return stdClass $role
+     * @return stdClass|null $role
      */
-    protected static function get_role($id): stdClass {
+    protected static function get_role($id): ?stdClass {
         $roles = (array) role_get_names();
         if (is_numeric($id) && isset($roles[$id])) {
             return (object) $roles[$id];
@@ -196,6 +196,7 @@ protected static function get_role($id): stdClass {
                 return $role;
             }
         }
+        return null;
     }
 
     /**