MDL-79991: Backport MDL-78061 Subplugin implementation to 4.1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MDL-76551 mod_bigbluebuttonbn: Refactor join url
* get_join url should not have as many parameters as they can be deduced from the instance.
* Refactoring it will allow to pass on more implicit parameters like the user profile file.
* MDL-76710 mod_bigbluebuttonbn: Subplugin implementation
* Setup the base for extension type of plugins
* Add basic unit test for extension plugin (callback and classes)
* MDL-76710 mod_bigbluebuttonbn: Action URL addons subplugin
* Add action URL extension point
* MDL-78062 mod_bigblubuttonbn: Add backup for subplugin
* MDL-78907 mod_bigbluebuttonbn: Refactor instance class
* Make the constructor private as it should only be instancied through
static methods
* Do not duplicate the code between get_from_instanceid,
get_from_cmid and get_all_instances_in_course
* MDL-78907 mod_bigbluebuttonbn: Get cm when necessary
* The constructor of mod_bigbluebuttonbn\instance was provided with a cm_info.
This forced us to retrieve it whenever we created an instance. The issue is that
sometimes we need all the "other" data but not necessarily the cm_info.
So we now lazy load it.
* MDL-78907 mod_bigbluebuttonbn: Use the correct parameter type for id
* MDL-77545 mod_bigbluebuttonbn: Refactor get_instances_implementing
* We need a way to either have the classes implementing an interface/abstract
class or create instances.
* MDL-77545 mod_bigbluebuttonbn: Add form extension
* Add a new way to extend the BigBlueButtonBN form via subplugins
* Allow subplugins to extends information via new tables and use it in
the edit form.
* Add a new cache helping with potential perfomance issues introduced
by recurring calls to find out about associated tables in subplugins.
* MDL-78960 mod_bigbluebuttonbn: Add instanceid as action parameter
* In the bigbluebutton_proxy::action_url call to submodules, we need a way to get
the instance this is called upon so we can have information (parameters) for
this instance settings (like the new settings introduced by subplugins).
* Add the optional instanceid parameter in join/create/getMeetingInfo calls
* MDL-79255 mod_bigbluebuttonbn: Allow subplugins to be uninstalled
* Allow subplugins to be uninstalled
* fixup! MDL-77545 mod_bigbluebuttonbn: Add form extension
* MDL-79991 mod_bigbluebuttonbn: Fix code checker related issues
* Made a separate commit so to be able to port it again to master.
---------
Co-authored-by: Huong Nguyen <[email protected]>
jfederico
pushed a commit
that referenced
this pull request
Mar 18, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
jfederico
pushed a commit
that referenced
this pull request
Apr 26, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
jfedericobn
pushed a commit
that referenced
this pull request
Jul 8, 2024
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
jfederico
pushed a commit
that referenced
this pull request
Oct 10, 2024
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
jfederico
pushed a commit
that referenced
this pull request
Oct 10, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been opened as a reference for the "unofficial" patch supported by BN.