Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env added #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ services:
dockerfile: Dockerfile.dev
ports:
- "3000:3000"
environment:
- REACT_APP_PORT=80
networks:
- fondant-network
volumes:
Expand Down
2 changes: 2 additions & 0 deletions frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ COPY . ./
RUN npm run build
RUN npm install -g serve
COPY . ./
ARG REACT_APP_PORT
ENV REACT_APP_PORT=${REACT_APP_PORT}
EXPOSE 3000
CMD ["serve", "-s", "build", "-l", "3000"]
2 changes: 1 addition & 1 deletion frontend/src/constant.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const NUM_OF_NODES_CONSIDERED_RUNNING = 5
export const DEFAULT_NODE_NUMBER = 1
export const NODE_URL = "http://localhost"
export const NODE_URL = `http://localhost:${process.env.REACT_APP_PORT}`
export const NODE_URL_PORT = "http://localhost:3001"