fix: wrong type in verb request defaults

block · Jan 17, 2025 · 3146934 · 3146934
1 parent e11c8cd
commit 3146934
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/frontend/console/src/features/modules/decls/verb/VerbPage.tsx b/frontend/console/src/features/modules/decls/verb/VerbPage.tsx
@@ -63,7 +63,7 @@ export const VerbPage = ({ moduleName, declName }: { moduleName: string; declNam
       <div className='flex flex-col h-full'>
         <div className='flex h-full'>
           <ResizablePanels
-            mainContent={<VerbRequestForm module={module} verb={verb} />}
+            mainContent={<VerbRequestForm key={`${module.name}-${verb.verb?.name}`} module={module} verb={verb} />}
             rightPanelHeader={header}
             rightPanelPanels={verbPanels(verb, callers)}
             bottomPanelContent={<TraceRequestList module={module.name} verb={verb.verb?.name} />}

diff --git a/frontend/console/src/features/modules/decls/verb/verb.utils.ts b/frontend/console/src/features/modules/decls/verb/verb.utils.ts
@@ -72,7 +72,7 @@ export const defaultRequest = (verb?: Verb): string => {
 
   if (!verb.jsonRequestSchema) {
     const defaultValue = verb.verb?.request ? defaultForType(verb.verb.request) : null
-    return defaultValue ? JSON.stringify(defaultValue, null, 2) : '{}'
+    return defaultValue !== null ? JSON.stringify(defaultValue, null, 2) : '{}'
   }
 
   const schema = simpleJsonSchema(verb)

diff --git a/frontend/console/src/features/timeline/details/TimelineCallDetails.tsx b/frontend/console/src/features/timeline/details/TimelineCallDetails.tsx
@@ -18,12 +18,12 @@ export const TimelineCallDetails = ({ event }: { event: Event }) => {
       </div>
 
       <div className='text-sm pt-2'>Request</div>
-      <CodeBlock code={JSON.stringify(JSON.parse(call.request), null, 2)} language='json' />
+      <CodeBlock code={call.request ? JSON.stringify(JSON.parse(call.request || '{}'), null, 2) : ''} language='json' />
 
       {call.response !== 'null' && (
         <>
           <div className='text-sm pt-2'>Response</div>
-          <CodeBlock code={JSON.stringify(JSON.parse(call.response), null, 2)} language='json' />
+          <CodeBlock code={JSON.stringify(JSON.parse(call.response || '{}'), null, 2)} language='json' />
         </>
       )}
 

diff --git a/frontend/console/src/features/traces/TraceGraph.tsx b/frontend/console/src/features/traces/TraceGraph.tsx
@@ -83,7 +83,6 @@ export const TraceGraph = ({ requestKey, selectedEventId }: { requestKey?: strin
   const startTime = requestStartTime(events)
   const totalEventDuration = totalDurationForRequest(events)
 
-  console.log(events)
   return (
     <div className='flex flex-col'>
       {events.map((c, index) => (