Skip to content

Commit

Permalink
fix: schema popup window clipping (#4075)
Browse files Browse the repository at this point in the history
  • Loading branch information
wesbillman authored Jan 16, 2025
1 parent 275cf7f commit cac8d58
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 16 deletions.
14 changes: 7 additions & 7 deletions examples/go/echo/types.ftl.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/console/src/components/ResizablePanels.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export const ResizablePanels: React.FC<ResizablePanelsProps> = ({
width: `${rightPanelWidth}px`,
maxHeight: bottomPanelContent ? `calc(100vh - ${bottomPanelHeight + TOP_BAR_HEIGHT}px)` : '100vh',
}}
className='flex flex-col h-full overflow-y-scroll'
className='flex flex-col h-full overflow-y-scroll overflow-x-visible'
>
<RightPanel header={rightPanelHeader} panels={rightPanelPanels} />
</div>
Expand Down
2 changes: 1 addition & 1 deletion frontend/console/src/features/modules/ModulePanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const ModulePanel = () => {
if (!module) return

return (
<div ref={ref} className='mt-4 mx-4'>
<div ref={ref} className='mt-4 mx-4 h-full'>
<Schema schema={module.schema} />
</div>
)
Expand Down
14 changes: 8 additions & 6 deletions frontend/console/src/features/modules/ModulesPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@ export const ModulesPage = ({ body }: { body: React.ReactNode }) => {
}

return (
<ResizableHorizontalPanels
leftPanelContent={<ModulesTree modules={tree} />}
rightPanelContent={body}
leftPanelWidth={treeWidth}
setLeftPanelWidth={setTreeWidthWithLS}
/>
<div className='h-full'>
<ResizableHorizontalPanels
leftPanelContent={<ModulesTree modules={tree} />}
rightPanelContent={body}
leftPanelWidth={treeWidth}
setLeftPanelWidth={setTreeWidthWithLS}
/>
</div>
)
}
2 changes: 1 addition & 1 deletion frontend/console/src/features/modules/schema/Schema.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const Schema = ({ schema, moduleName, containerRect }: { schema: string;
</div>
))
return (
<div className='overflow-x-auto'>
<div className='overflow-x-auto h-full'>
<div className='whitespace-pre font-mono text-xs'>{lines}</div>
</div>
)
Expand Down

0 comments on commit cac8d58

Please sign in to comment.