fix: ensure all refs except builtins are fully qualified #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
Open
alecthomas
force-pushed
the
aat/fix-unqualified-refs
branch
from
66e550d to
f270102
Compare
This changes validation such that all refs except builtins, but including self references must be fully qualified.
alecthomas
force-pushed
the
aat/fix-unqualified-refs
branch
from
f270102 to
ef08bdd
Compare
|
@TBD54566975/ftl-team FYI I moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes validation such that all refs except builtins, but including self references must be fully qualified.