-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove runners and ingress from dal GetStatus #1280
Conversation
lgtm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I guess the ticket wasn't clear - what it meant was to get rid of the ability to select all controllers/runners, etc. not get rid of the ability to retrieve active runners/controllers altogether. Please revert and adjust.
bool all_controllers = 2; | ||
bool all_ingress_routes = 3; | ||
|
||
reserved 1, 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this, as Wes mentioned, we don't bother with preserving proto compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, makes sense
message Route { | ||
string module = 1; | ||
string runner = 2; | ||
string deployment = 3; | ||
string endpoint = 4; | ||
} | ||
repeated Route routes = 5; | ||
|
||
reserved 2, 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, makes sense
Fixes issue #1171
This PR includes some proto field deletions following the guidance here: https://protobuf.dev/programming-guides/proto3/#deleting
Manually tested
ftl serve
andftl status
(the two commands that referenceStatusRequest
) and got the desired output: