fix: skip validation on external req/resp types #1304
Conversation
We don't have access to the full schema at this point, so we can't validate that external types exist
wesbillman
force-pushed
the
skip-validation-on-external-reqresp-types
branch
from
711c898 to
3fb2f6e
Compare
| bodySym := scopes.ResolveType(fieldType) | ||
| if bodySym == nil { | ||
| merr = append(merr, errorf(resp, "ingress verb %s: couldn't resolve %s body type %s", n.Name, reqOrResp, fieldType)) | ||
| merr = append(merr, errorf(r, "ingress verb %s: couldn't resolve %s body type %s", n.Name, reqOrResp, fieldType)) |
There was a problem hiding this comment.
This fixes the issue where initial deploy failed: 14:3-3: ingress verb getQuote: is returned as an error. This was because of a typo that used resp instead of r for the errorf( call
| if ref, err := ParseRef(fieldType.String()); err == nil { | ||
| if ref.Module != "" && ref.Module != module.Name { | ||
| return // ignores references to other modules. | ||
| } | ||
| } |
There was a problem hiding this comment.
This introduces logic to not validate resp body types for external modules since we don't have the full schema here, just a single module. This follows the comments for ValidateModule
// ValidateModule performs the subset of semantic validation possible on a single module.
//
// It ignores references to other modules.
func ValidateModule(module *Module) error {
There was a problem hiding this comment.
Does this get validated in ValidateSchema instead now? I don't see that in this PR.
There was a problem hiding this comment.
Yeah I believe that code is here:
https://github.com/TBD54566975/ftl/blob/main/backend/schema/validate.go#L137
and tested here:
https://github.com/TBD54566975/ftl/blob/main/backend/schema/schema_test.go#L211-L214
We don't have access to the full schema at this point, so we can't validate that external types exist
Fixes #1298