Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return early from ftl dev when incompatible flags (--stop --no-serve) are used #1325

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

deniseli
Copy link
Contributor

Fixes #1167

Manually tested:

$ ftl dev --stop --no-serve ./examples/go --log-level=trace
trace: Loading config from /Users/dli/Development/ftl/ftl-project.toml
debug: FTL serve is not running in the background
$ ftl serve --background
info: `ftl serve` running in background with pid: 42320
$ ftl dev --stop --no-serve ./examples/go --log-level=trace
trace: Loading config from /Users/dli/Development/ftl/ftl-project.toml
info: `ftl serve` stopped (pid: 42320)

return early
@deniseli deniseli requested a review from a team as a code owner April 24, 2024 19:57
@deniseli deniseli requested review from wesbillman and removed request for a team April 24, 2024 19:57
@alecthomas alecthomas mentioned this pull request Apr 24, 2024
@deniseli deniseli merged commit bbc214d into main Apr 24, 2024
12 checks passed
@deniseli deniseli deleted the dli/conn-loop branch April 24, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ftl dev --no-serve --stop goes into a connection loop if the server isn't running
3 participants