fix: prevent duplicate configs, secrets, databases within module #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
reviewed
Apr 26, 2024
| dbs := make(map[string]int) | ||
|
|
||
| for i, d := range decls { | ||
| c, ok := d.(*Config) |
There was a problem hiding this comment.
Use a type switch here instead of these separate individual type conversions:
switch d := d.(type) {
case *Config:
}| configs[c.Name] = []int{i} | ||
| continue | ||
| } | ||
| matchIdx, foundMatch := ftlslices.Find(configs[c.Name], func(j int) bool { |
There was a problem hiding this comment.
What's the purpose of this? Can't the maps just be map[string]*Config, and if one already exists you report it as an error?
There was a problem hiding this comment.
Oh my, I somehow forgot pointers existed. Fixing this now whoops
|
fw fix in #1337 |
deniseli
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1121
This adds backend schema validation preventing duplicate configs, secrets, and databases within a module. This also adds go-runtime validation preventing duplicate databases. Go-runtime validation for duplicate configs/secrets was added in PR #1328