fix: fall back to global secrets was not working #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
commented
Apr 26, 2024
|
|
||
| func (p *InMemoryProvider[R]) Load(ctx context.Context, ref Ref, key *url.URL) ([]byte, error) { | ||
| if bytes, found := p.values[ref]; found { | ||
| return bytes, nil | ||
| } | ||
| return nil, fmt.Errorf("key %q not found", ref.Name) | ||
| return nil, ErrNotFound |
There was a problem hiding this comment.
This specific error must be used
Open
matt2e
commented
Apr 26, 2024
| gref := ref | ||
| gref.Module = optional.None[string]() | ||
| key, err = m.resolver.Get(ctx, gref) | ||
| ref.Module = optional.None[string]() |
There was a problem hiding this comment.
If global config/secret is found, we need the ref var to point to it as it is used to access it from the provider.
Previously, resolver would match the global ref, but we would then use the module specific ref with the provider.
matt2e
commented
Apr 26, 2024
| @@ -18,13 +18,13 @@ func NewInMemoryProvider[R Role]() *InMemoryProvider[R] { | |||
| } | |||
|
|
|||
| func (p *InMemoryProvider[R]) Role() R { var r R; return r } | |||
| func (p *InMemoryProvider[R]) Key() string { return "grpc" } | |||
| func (p *InMemoryProvider[R]) Key() string { return "inmemory" } | |||
There was a problem hiding this comment.
clean up for an old refactor
matt2e
force-pushed
the
matt2e/missing-secrets
branch
from
9b521f2 to
4299e91
Compare
|
Thanks for the comments! Very helpful in understanding the changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1339