feat: MySql support #3427
Merged
feat: MySql support #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
worstell and
wesbillman
and removed request for
a team
This was referenced Nov 18, 2024
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/mysql
branch
11 times, most recently
from
469c8ab to
2517aec
Compare
alecthomas
reviewed
Nov 20, 2024
internal/modulecontext/database.go
Outdated
| ) | ||
|
|
||
| func DBTypeFromString(dt string) DBType { | ||
| switch dt { |
There was a problem hiding this comment.
Maybe this should be a case insensitive match? FromString() should be able to round-trip from .String()
alecthomas
approved these changes
Nov 20, 2024
internal/modulecontext/database.go
Outdated
| func (x DBType) String() string { | ||
| switch x { | ||
| case DBTypePostgres: | ||
| return "Postgres" | ||
| case DBTypeMySQL: | ||
| return "MySQL" |
There was a problem hiding this comment.
I think let's make these lowercase, as that seems to be what they are everywhere else.
stuartwdouglas
force-pushed
the
stuartwdouglas/mysql
branch
5 times, most recently
from
357a2a8 to
d4134a6
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/mysql
branch
2 times, most recently
from
e2be61a to
b22b40a
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/mysql
branch
2 times, most recently
from
0f4d4c9 to
bbac4c8
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/mysql
branch
from
bbac4c8 to
a273e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds local provisioning via docker and wires up some of the MySQL support.
Still slightly WIP as I have run out of time to fully test it, but it works with Java apps.