fix: speed up pubsub provisioning #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
force-pushed
the
matt2e/pubsub/provisioning-perf
branch
from
4a9bdfc to
4cb8b82
Compare
jvmakine
approved these changes
Jan 7, 2025
matt2e
force-pushed
the
matt2e/pubsub/provisioning-perf
branch
from
85bf35f to
5dac907
Compare
matt2e
added a commit
that referenced
this pull request
Jan 7, 2025
Fixes a race condition where multiple go routines would try and append to the same slice concurrently. We would end up losing some RuntimeEvents. The fix involves publishing to a channel, aggregating the events and then marking the step as complete. I only started seeing the bug when pubsub provisioning began completing multiple steps in quick succession: #3916
matt2e
force-pushed
the
matt2e/pubsub/provisioning-perf
branch
from
5dac907 to
b189cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3901
prerequisite: #3917
Wraps
docker compose upwith a lock and a cached success flag.