Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused DeploymentArtefactCreatedEvent #3918

Merged
merged 2 commits into from
Jan 7, 2025
Merged

refactor: Remove unused DeploymentArtefactCreatedEvent #3918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fa95f2
chore: remove unused "artifacts" from conroller state
jvmakine Jan 7, 2025
09c5cc5
chore: remove unused DeploymentArtefactEvent
jvmakine Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backend/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,10 +886,6 @@ func (s *Service) CreateDeployment(ctx context.Context, req *connect.Request[ftl
logger.Errorf(err, "Invalid digest %s", artefact.Digest)
return nil, fmt.Errorf("invalid digest: %w", err)
}
err = s.controllerState.Publish(ctx, &state.DeploymentArtefactCreatedEvent{})
if err != nil {
return nil, fmt.Errorf("could not create deployment artefact: %w", err)
}
artefacts[i] = &state.DeploymentArtefact{
Executable: artefact.Executable,
Path: artefact.Path,
Expand Down
1 change: 0 additions & 1 deletion backend/controller/state/controllerstate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ type State struct {
activeDeployments map[string]*Deployment
runners map[string]*Runner
runnersByDeployment map[string][]*Runner
artifacts map[string]bool
}

type ControllerEvent interface {
Expand Down
11 changes: 0 additions & 11 deletions backend/controller/state/deployment_artefacts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,3 @@ type DeploymentArtefact struct {
Path string
Executable bool
}

var _ ControllerEvent = (*DeploymentArtefactCreatedEvent)(nil)

type DeploymentArtefactCreatedEvent struct {
Digest sha256.SHA256
}

func (d *DeploymentArtefactCreatedEvent) Handle(view State) (State, error) {
view.artifacts[d.Digest.String()] = true
return view, nil
}
Loading