fix: use proto to communicate with Hot Reload process #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-fixes
branch
12 times, most recently
from
36ff443 to
0e516cf
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-fixes
branch
2 times, most recently
from
76f9c92 to
afd4454
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/hot-reload-fixes
branch
from
2cb3601 to
163248f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is that gRPC is now used to communicate between the JVM hot reload process and the plugin. This will allow FTL to have more control over the process, rather than relying on the Quarkus native hot reload behaviour.
This is stage one of the refactoring, it removes the runner-info file and move responsibility for initiating reload to the plugin.