chore: remove use of dbmate as a library #4325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reality our uses of it are very straightforward, and it pulls in a bunch of deps we don't want or need.
|
|
||
| // Create schema_migrations table if it doesn't exist. | ||
| // This table structure is compatible with dbmate. | ||
| _, _ = db.ExecContext(ctx, `CREATE TABLE schema_migrations (version TEXT PRIMARY KEY)`) //nolint:errcheck |
There was a problem hiding this comment.
If we add a digest column here we could detect when the migration has failed for local dev.
There was a problem hiding this comment.
That is a great idea. When we revisit we should do that.
|
I sank way too much time into this already, so I'm giving up for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reality our uses of it are very straightforward, and it pulls in a bunch of deps we don't want or need.