feat: improve ftl dev rebuild algorithm
#932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed module builds will only retrigger if any of the following occur: 1. If the number of failed builds changes between one pass and the next. This is for the case when we're iteratively trying to bring up the entire graph. 2. If zero builds have succeeded. This catches the case where no builds are able to start initially because FTL isn't up yet. 3. Finally, if any files change in a module. This catches changes due to the normal development cycle. I also decreased the failure delay, because we don't inifinitely spam rebuilds anymore.
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed module builds will only retrigger if any of the following occur:
I also decreased the failure delay, because we don't inifinitely spam rebuilds anymore.
Fixes #914