chore: implement encoding.Unmarshal #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20240222-add-encoding-unmarshal
branch
from
e7d8bf8 to
8606043
Compare
alecthomas
requested changes
Feb 23, 2024
| v = v.Elem() | ||
| fallthrough | ||
|
|
||
| case t.Implements(jsonUnmarshaler): | ||
| case t.Implements(jsonMarshaler): |
go-runtime/encoding/encoding.go
Outdated
| if _, ok := jsonData[jsonKey]; ok { | ||
| fieldTypeStr := fieldType.Type.String() | ||
| switch { | ||
| case fieldTypeStr == "*Unit" || fieldTypeStr == "Unit": |
There was a problem hiding this comment.
This could be a direct comparison with reflect.TypeOf(ftl.Unit{}) et al?
There was a problem hiding this comment.
this introduces a dependency cycle because ftl depends on encoding (it's used in option.go)
alecthomas
reviewed
Feb 23, 2024
alecthomas
reviewed
Feb 23, 2024
alecthomas
reviewed
Feb 23, 2024
worstell
force-pushed
the
worstell/20240222-add-encoding-unmarshal
branch
2 times, most recently
from
6af7298 to
6a2bfec
Compare
worstell
force-pushed
the
worstell/20240222-add-encoding-unmarshal
branch
from
6a2bfec to
8a7617c
Compare
good idea! updated |
worstell
force-pushed
the
worstell/20240222-add-encoding-unmarshal
branch
from
8a7617c to
e83e33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #971
fixes #951