fix: don't convert to cip129 non-drep voters

blockfrost · Dec 13, 2024 · 443278d · 443278d
1 parent 1492789
commit 443278d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,9 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Support for CIP129 DRep ID - you can query DReps using both legacy format and CIP129 format. The `drep_id` and `hex` fields will reflect the format of the query param
+
 ### Changed
 
-- looser validation for cost model size
+- BREAKING CHANGE: Endpoints `/governance/dreps` and `/governance/proposals/{tx_hash}/{cert_index}/votes` are now using CIP129 format
+- Looser validation for cost model size in `epochs/:num/parameters`
 
 ## [2.4.0] - 2024-11-20
 

diff --git a/src/routes/governance/proposals/tx-hash/cert-index/votes.ts b/src/routes/governance/proposals/tx-hash/cert-index/votes.ts
@@ -37,7 +37,12 @@ async function route(fastify: FastifyInstance) {
         gracefulRelease(clientDbSync);
 
         for (const row of rows) {
-          // Convert voter id to cip129 format
+          if (!row.voter.startsWith('drep')) {
+            // Keep non-DRep voter unmodified
+            continue;
+          }
+
+          // Convert voter id to CIP129 format
           const cip129DRep = dbSyncDRepToCIP129({
             drep_id: row.voter,
             has_script: row.voter_has_script,

diff --git a/src/utils/governance.ts b/src/utils/governance.ts
@@ -38,13 +38,11 @@ export const dbSyncDRepToCIP129 = <T extends { drep_id: string; has_script: bool
 };
 
 export interface DRepValidationResult {
-  // TODO: maybe rename to raw, raw prop to hex,
   dbSync: {
     id: string;
     raw: string | null;
     hasScript: boolean;
   };
-  // cip129 is set when the bechDrepId
   cip129: {
     // CIP129 bech32 representation of dRep ID
     id: string;
@@ -183,7 +181,6 @@ export const validateDRepId = (bechDrepId: string): DRepValidationResult => {
  * @param {{drep_id: string; hex: string}} data - DRep dbsync data
  * @returns Object - DRep data object with CIP-0129 compatible bech32 ID and hex in case of CIP-0129 drepId. Otherwise the data remain unmodified.
  *
- * @throws {Error} If the DRep ID prefix is invalid, an error is thrown.
  */
 export const enhanceDRep = <T extends { drep_id: string; hex: string }>(
   data: T,