13 make nameful compliant with the new ensip #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pikonha
reviewed
Feb 10, 2025
lib/abi/arbitrum-resolver.json
Outdated
There was a problem hiding this comment.
I think it is better to call it offchain-resolver since it will be used by any layer 2.
lib/abi/resolver.json
Outdated
There was a problem hiding this comment.
what's the difference between this abi the arbitrum-resolver one?
| { | ||
| name: dnsName, | ||
| owner: signerAddress, | ||
| duration: SECONDS_PER_YEAR.seconds * BigInt(1000), |
There was a problem hiding this comment.
I think that should be seconds instead of ms
There was a problem hiding this comment.
apparently subdomain registration has expiration set to 0, see this tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.