Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offchain resolver namewrapper based interface #225

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Offchain resolver namewrapper based interface #225

merged 7 commits into from
Oct 21, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Oct 8, 2024 •
edited
Loading

Offchain resolver namewrapper based interface

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The register function described by the Offchain Resolver interface should have the parentNode as the first argument to enable subdomain registration for any given 2LD.

Related Issue

#220

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

@pikonha pikonha added the enhancement New feature or request label Oct 8, 2024
@pikonha pikonha added this to the Layer 2 implementation milestone Oct 8, 2024
@pikonha pikonha self-assigned this Oct 8, 2024
@pikonha pikonha linked an issue Oct 8, 2024 that may be closed by this pull request
Offchain Resolver nameWrapper based interface #220
Closed
@pikonha pikonha changed the title 220 offchain resolver namewrapper based interface Offchain resolver namewrapper based interface Oct 8, 2024
alextnetto
alextnetto approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@alextnetto alextnetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

packages/client/src/l2.write.ts Outdated
@@ -105,13 +108,13 @@ const _ = (async () => {
functionName: 'register',
abi: l1Abi,
args: [
name,
dnsName, // name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change dnsName to encodedName

@pikonha pikonha merged commit bbd353f into main Oct 21, 2024
1 check passed
@pikonha pikonha deleted the 220-offchain-resolver-namewrapper-based-interface branch October 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextnetto alextnetto alextnetto approved these changes

@LeonardoVieira1630 LeonardoVieira1630 Awaiting requested review from LeonardoVieira1630 LeonardoVieira1630 is a code owner

Assignees

@pikonha pikonha

Labels
enhancement New feature or request
Projects
ENS
Status: ✅ Done
Milestone
Layer 2 implementation
Development

Successfully merging this pull request may close these issues.

Offchain Resolver nameWrapper based interface
2 participants
@pikonha @alextnetto