Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple register func #247

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Decouple register func #247

merged 11 commits into from
Jan 31, 2025

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Jan 20, 2025

Decouple functions from the register

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The register function now doesn't handle setting records, setting resolver, and setting primary name. These functions are now redirected to the respective contract through the getDeferralHandler view call.

Related Issue

#239
#246

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

@pikonha pikonha added the enhancement New feature or request label Jan 20, 2025
@pikonha pikonha self-assigned this Jan 20, 2025
@pikonha pikonha changed the title Decouple register func Decouple register func L2 Jan 20, 2025
Base automatically changed from wildcard-writing-v02 to main January 21, 2025 12:37
@pikonha pikonha changed the title Decouple register func L2 Decouple register func Jan 21, 2025
@pikonha pikonha force-pushed the decouple-register-func branch from 8438b27 to 72f836a Compare January 24, 2025 20:30
@pikonha pikonha merged commit be49701 into main Jan 31, 2025
1 check passed
@pikonha pikonha deleted the decouple-register-func branch January 31, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant