Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tooltips and helpUrls #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grintor
Copy link

@grintor grintor commented Jun 4, 2020

I have populated the helpurl and tooltips for a bunch of the blocks. The tooltips are pulled mostly from the first sentence of the links that the helpurl points to. The helpurls are all from the official python 3 documentation. This makes it easy for users unfamiliar with the syntax to figure out what's going on. Easier, I would say, than if they were working with non-block version of the code, which is pretty cool

@acbart
Copy link
Collaborator

acbart commented Jun 5, 2020

Oh hey, this is great! I'll definitely be accepting this pull request. Thanks for contributing!

My only desired change is to extract out the Switch statement work in ast_Call.js into a dictionary that we import. That file is already pretty long and complicated, and that's more "varying data" than "varying control flow". If you're up for the change, please do so - otherwise I'll find some time next week to make the change myself.

@grintor
Copy link
Author

grintor commented Jun 8, 2020

Thanks,

I think you will need to be the one to make the changes because I have had trouble getting any version of blockmirror to compile, so can't actually test this PR. I am confident that the changes here are superficial enough that I didn't break anything, but any more complexity and I would be concerned. That said, do you have any guide on compiling this? I think there might be a dependency that needs to be an older version somewhere, it's been a while since I tried, so I can't remember the error I was getting.

I have been just using the release dist, which thankfully has not been minified, so I have been able to work on it without needing to compile yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants