Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: token factory #15

Merged
merged 5 commits into from
Jan 24, 2025
Merged

refactor: token factory #15

merged 5 commits into from
Jan 24, 2025

Conversation

scottphc
Copy link
Member

@scottphc scottphc commented Jan 23, 2025 •
edited
Loading

  • use OwnableUpgradeable instead
  • remove unused functions, variables
  • remove weth param
  • rename variable for better readability
  • check parent IPAccount and derivData

@scottphc scottphc marked this pull request as ready for review January 24, 2025 03:59
@scottphc scottphc force-pushed the feature/refactor-token-factory branch from 4f5157d to 90db2e9 Compare January 24, 2025 04:40
@scottphc scottphc merged commit 5384c9a into main Jan 24, 2025
2 checks passed
@scottphc scottphc deleted the feature/refactor-token-factory branch January 24, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhsuan19 yuhsuan19 yuhsuan19 approved these changes

@q20274982 q20274982 Awaiting requested review from q20274982

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottphc @yuhsuan19