Feat/trading on dex #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q20274982
force-pushed
the
feat/trading-on-dex
branch
from
302a0e7 to
e773645
Compare
yuhsuan19
reviewed
Jan 10, 2025
|
|
||
| uint256 deltaY = (exp_b_x1 - exp_b_x0).fullMulDiv(A, B); | ||
|
|
||
| // adjust for 12 decimal places difference between deltaY and basedTokensIn |
| @@ -170,6 +157,7 @@ interface ISpotlightTokenFactory { | |||
|
|
|||
| /** | |||
| * @dev Creates a new token with the specified parameters and initializes it. | |||
| * @notice Creation fee must be paid in native token. | |||
| * @param tokenCreationData Details for creating the token. | |||
| * @param initialBuyData Details for the initial purchase of the token. | |||
| * @param derivData Details for creating a derivative token. See {IStoryDerivativeWorkflows-registerIpAndMakeDerivative}. | |||
There was a problem hiding this comment.
suggestion: include description for newly added params
| abstract contract SpotlightTokenStorage { | ||
| // @dev v1 properties | ||
| uint256 public constant BONDING_CURVE_SUPPLY = 800_000_000e18; // 0.8 billion | ||
| uint256 public constant PROTOCOL_TRADING_FEE_PCT = 1; // 1% | ||
| uint256 public constant MIN_USDC_ORDER_SIZE = 100; // 0.0001 USDC | ||
| uint256 public constant PROTOCOL_TRADING_FEE_PCT = 9_000; // 90% |
| @@ -21,6 +32,13 @@ contract SpotlightToken is BeaconProxyStorage, InitializableERC20, SpotlightToke | |||
| _; | |||
| } | |||
|
|
|||
| error SlippageBoundsExceeded(); | |||
| error EthTransferFailed(); | |||
| error InvalidMarketType(); | ||
| error InsufficientLiquidity(); | ||
| error AddressZero(); | ||
| error EthAmountTooSmall(); |
|
ISpotlightTokenFactory.sol |
|
感覺可以把上一支關掉，這支直接進develop |
yuhsuan19
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPEC
Wow