reject in watchAsset to indicate failure

blocto · May 2, 2022 · d2c6c1f · d2c6c1f
1 parent 320a2e1
commit d2c6c1f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/packages/coinbase-wallet/src/index.ts b/packages/coinbase-wallet/src/index.ts
@@ -195,8 +195,8 @@ export class CoinbaseWallet extends Connector {
     symbol,
     decimals,
     image,
-  }: Pick<WatchAssetParameters, 'address'> & Partial<Omit<WatchAssetParameters, 'address'>>): Promise<boolean> {
-    if (!this.provider) return false
+  }: Pick<WatchAssetParameters, 'address'> & Partial<Omit<WatchAssetParameters, 'address'>>): Promise<true> {
+    if (!this.provider) throw new Error('No provider')
 
     return this.provider
       .request({
@@ -211,10 +211,9 @@ export class CoinbaseWallet extends Connector {
           },
         },
       })
-      .then((success) => success as boolean)
-      .catch((error) => {
-        console.debug(error)
-        return false
+      .then((success) => {
+        if (!success) throw new Error('Rejected')
+        return true
       })
   }
 }
diff --git a/packages/metamask/src/index.ts b/packages/metamask/src/index.ts
@@ -165,8 +165,8 @@ export class MetaMask extends Connector {
       })
   }
 
-  public async watchAsset({ address, symbol, decimals, image }: WatchAssetParameters): Promise<boolean> {
-    if (!this.provider) return false
+  public async watchAsset({ address, symbol, decimals, image }: WatchAssetParameters): Promise<true> {
+    if (!this.provider) throw new Error('No provider')
 
     return this.provider
       .request({
@@ -181,10 +181,9 @@ export class MetaMask extends Connector {
           },
         },
       })
-      .then((success) => success as boolean)
-      .catch((error) => {
-        console.debug(error)
-        return false
+      .then((success) => {
+        if (!success) throw new Error('Rejected')
+        return true
       })
   }
 }
diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -127,5 +127,5 @@ export abstract class Connector {
   /**
    * Attempt to add an asset per EIP-747
    */
-  public watchAsset?(params: WatchAssetParameters): Promise<boolean>
+  public watchAsset?(params: WatchAssetParameters): Promise<true>
 }