Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add first set of seeds tokens #4

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

emilyjablonski
Copy link

@emilyjablonski emilyjablonski commented Nov 25, 2024

This PR addresses bloom-housing#4485

  • Addresses the issue in full

Description

Adds the first set of Seeds tokens, will will theme colors, fonts, and buttons where Seeds exists in core.

How Can This Be Tested/Reviewed?

Check out the public site deploy preview! We'll have very partial theming.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for bloom-detroit ready!

Name Link
🔨 Latest commit fa60da8
🔍 Latest deploy log https://app.netlify.com/sites/bloom-detroit/deploys/674fb678c7161a00087e5f50
😎 Deploy Preview https://deploy-preview-4--bloom-detroit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for bloom-detroit-partners ready!

Name Link
🔨 Latest commit fa60da8
🔍 Latest deploy log https://app.netlify.com/sites/bloom-detroit-partners/deploys/674fb6783ff7160008ea452f
😎 Deploy Preview https://deploy-preview-4--bloom-detroit-partners.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -26,7 +26,7 @@ export const getListingStatusTag = (listingStatus: ListingsStatusEnum) => {
return (
<Tag
className="tag-uppercase"
variant={"in-process"}
variant={"warn"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we weren't going to touch partners as much as possible. Putting the appropriate footer makes sense, but I'm curious what this change was for?

@@ -17,7 +17,7 @@
},
"dependencies": {
"@bloom-housing/ui-components": "12.4.0",
"@bloom-housing/ui-seeds": "1.17.0",
"@bloom-housing/ui-seeds": "^1.18.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Ideally we will only be updating dependencies in core so our package and yarn files stay in sync and we don't run into any weirdness with deployments because of discrepancies

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted! 🫡

@emilyjablonski
Copy link
Author

Because I reverted the token change, the color of the header is going to be one shade darker than in the designs. I need to connect w Jesse about a token mismatch issue.

Copy link

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@emilyjablonski emilyjablonski merged commit 228456d into main Dec 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants