-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add first set of seeds tokens #4
Conversation
✅ Deploy Preview for bloom-detroit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-detroit-partners ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -26,7 +26,7 @@ export const getListingStatusTag = (listingStatus: ListingsStatusEnum) => { | |||
return ( | |||
<Tag | |||
className="tag-uppercase" | |||
variant={"in-process"} | |||
variant={"warn"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we weren't going to touch partners as much as possible. Putting the appropriate footer makes sense, but I'm curious what this change was for?
shared-helpers/package.json
Outdated
@@ -17,7 +17,7 @@ | |||
}, | |||
"dependencies": { | |||
"@bloom-housing/ui-components": "12.4.0", | |||
"@bloom-housing/ui-seeds": "1.17.0", | |||
"@bloom-housing/ui-seeds": "^1.18.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Ideally we will only be updating dependencies in core so our package and yarn files stay in sync and we don't run into any weirdness with deployments because of discrepancies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted! 🫡
1f9fadd
to
8725070
Compare
Because I reverted the token change, the color of the header is going to be one shade darker than in the designs. I need to connect w Jesse about a token mismatch issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏
This PR addresses bloom-housing#4485
Description
Adds the first set of Seeds tokens, will will theme colors, fonts, and buttons where Seeds exists in core.
How Can This Be Tested/Reviewed?
Check out the public site deploy preview! We'll have very partial theming.
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: