fix: add home type feature to backend and partners #4484

ludtkemorgan · 2024-11-20T01:42:11Z

This PR addresses #4432, #4431

Addresses the issue in full
Addresses only certain aspects of the issue

Description

Adds the "Home Type" select option to the listing create/edit page as well as connecting HomeType to the listing create endpoint, edit endpoint, and the CSV export.

This is also the first feature using the new feature flag table so some extra logic to utilize it has been added

NOTES:

I did not get approval from product/design on the location of this field in Partners. The Detroit location is slightly different because it is within the "Unit Group" section which doesn't exist in core. I will get confirmation on the location before merging of this PR.

How Can This Be Tested/Reviewed?

Reseed the database with staging data. This will add the new feature flag to the "Bloomington" jurisdiction
Go to partner site and create a new listing
Select Bloomington Jurisdiction and add a home type to the listing
Save listing and the home type should appear on the listing
Edit listing and change the home type. After save it should appear
Export the Listing CSV and the "Home Type" column should be there with the new listing's home type in the appropriate location

Other things you can test:

Verify the Home Type field doesn't appear on the UI if you have selected a different jurisdiction
If no jurisdiction has the home type feature flag turned on the CSV export should not have that column

Author Checklist:

Added QA notes to the issue with applicable URLs
Reviewed in a desktop view
Reviewed in a mobile view
Reviewed considering accessibility
Added tests covering the changes
Made corresponding changes to the documentation
Ran yarn generate:client and/or created a migration when required

Review Process:

Read and understand the issue
Ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

netlify · 2024-11-20T01:45:35Z

✅ Deploy Preview for partners-bloom-dev ready!

Name	Link
🔨 Latest commit	`1d0179b`
🔍 Latest deploy log	https://app.netlify.com/sites/partners-bloom-dev/deploys/674e6742ae38470008fcd774
😎 Deploy Preview	https://deploy-preview-4484--partners-bloom-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-11-20T01:45:51Z

✅ Deploy Preview for bloom-exygy-dev ready!

Name	Link
🔨 Latest commit	`1d0179b`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/674e6742b4efca00081cc388
😎 Deploy Preview	https://deploy-preview-4484--bloom-exygy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

accesslint

There are accessibility issues in these changes.

sites/partners/src/components/listings/PaperListingForm/sections/Units.tsx

accesslint

There are accessibility issues in these changes.

sites/partners/src/components/listings/PaperListingForm/sections/Units.tsx

shared-helpers/src/locales/es.json

sites/partners/tsconfig.json

YazeedLoonat

Looks good! 1 small nit

api/src/services/listing-csv-export.service.ts

emilyjablonski

Haven't peeked at the code yet, but a few functionality notes!

I think I would expect that between the detail and edit view, that the fields are in the same order - it looks like the new field is in each view above and then below the neighbor fields.

And then when I select a value and save it, it shows as saved on the detail page, but if I reopen the edit page, it doesn't populate with the value.

sites/partners/cypress/e2e/default/03-listing.spec.ts

shared-helpers/src/locales/general.json

sites/partners/src/components/listings/PaperListingDetails/sections/DetailUnits.tsx

sites/partners/src/components/listings/PaperListingForm/index.tsx

accesslint

There are accessibility issues in these changes.

sites/partners/src/components/listings/PaperListingForm/sections/Units.tsx

ludtkemorgan · 2024-12-03T02:06:21Z

@emilyjablonski Thanks for the review. Looks like I accidentally introduced the issue where the home type doesn't persist when editing with the useEffect. This has been fixed and you should be able to see the selected home type now.

I'll need to reach out to design about where to place the home type field as it doesn't really make a lot of sense in either of the spots. For now I updated the field to be in the same place for both edit and detail view

emilyjablonski

LGTM!

ludtkemorgan · 2024-12-04T14:55:55Z

I got confirmation from Em that the placement of the field is fine. We can revisit it if any non-detroit jurisdiction ever wants it

* fix: add hometype to listing create/update * fix: add home type to csv * fix: update jwt to retrieve feature flags * fix: partner changes * fix: have partner be behind feature flag * fix: backend test fix * fix: remove comment * fix: address comments * fix: review comments

… (#830) * fix: add hometype to listing create/update * fix: add home type to csv * fix: update jwt to retrieve feature flags * fix: partner changes * fix: have partner be behind feature flag * fix: backend test fix * fix: remove comment * fix: address comments * fix: review comments

* fix: add hometype to listing create/update * fix: add home type to csv * fix: update jwt to retrieve feature flags * fix: partner changes * fix: have partner be behind feature flag * fix: backend test fix * fix: remove comment * fix: address comments * fix: review comments

ludtkemorgan force-pushed the 4432/hometype branch from 376ed4f to 4da746a Compare November 20, 2024 16:33

ludtkemorgan added the on hold Temporarily paused work label Nov 20, 2024

ludtkemorgan added 4 commits November 26, 2024 13:51

fix: add hometype to listing create/update

e53d3b6

fix: add home type to csv

bf994e4

fix: update jwt to retrieve feature flags

3ffb95d

fix: partner changes

3bfde07

ludtkemorgan force-pushed the 4432/hometype branch from 4da746a to 3bfde07 Compare November 26, 2024 20:35

accesslint bot reviewed Nov 26, 2024

View reviewed changes

sites/partners/src/components/listings/PaperListingForm/sections/Units.tsx Outdated Show resolved Hide resolved

ludtkemorgan changed the title ~~fix: add hometype to listing create/update~~ fix: add home type feature to backend and partners Nov 26, 2024

fix: have partner be behind feature flag

3dfcc3a

accesslint bot reviewed Nov 26, 2024

View reviewed changes

sites/partners/src/components/listings/PaperListingForm/sections/Units.tsx Outdated Show resolved Hide resolved

fix: backend test fix

4b469a9

ludtkemorgan marked this pull request as ready for review November 26, 2024 23:20

ludtkemorgan added 2 reviews needed Requires 2 more review before ready to merge and removed on hold Temporarily paused work labels Nov 26, 2024

ludtkemorgan commented Nov 26, 2024

View reviewed changes

shared-helpers/src/locales/es.json Show resolved Hide resolved

ludtkemorgan commented Nov 26, 2024

View reviewed changes

sites/partners/tsconfig.json Outdated Show resolved Hide resolved

fix: remove comment

3858637

YazeedLoonat reviewed Dec 2, 2024

View reviewed changes

api/src/services/listing-csv-export.service.ts Outdated Show resolved Hide resolved

emilyjablonski requested changes Dec 2, 2024

View reviewed changes

emilyjablonski reviewed Dec 2, 2024

View reviewed changes

sites/partners/cypress/e2e/default/03-listing.spec.ts Show resolved Hide resolved

emilyjablonski reviewed Dec 2, 2024

View reviewed changes

shared-helpers/src/locales/general.json Show resolved Hide resolved

emilyjablonski reviewed Dec 2, 2024

View reviewed changes

sites/partners/src/components/listings/PaperListingDetails/sections/DetailUnits.tsx Outdated Show resolved Hide resolved

emilyjablonski reviewed Dec 2, 2024

View reviewed changes

sites/partners/src/components/listings/PaperListingForm/index.tsx Show resolved Hide resolved

emilyjablonski added needs changes The author must make changes and then re-request review before merging 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Dec 2, 2024

fix: address comments

19a16eb

accesslint bot reviewed Dec 2, 2024

View reviewed changes

sites/partners/src/components/listings/PaperListingForm/sections/Units.tsx Show resolved Hide resolved

fix: review comments

1d0179b

ludtkemorgan force-pushed the 4432/hometype branch from da215b3 to 1d0179b Compare December 3, 2024 02:04

ludtkemorgan removed the needs changes The author must make changes and then re-request review before merging label Dec 3, 2024

emilyjablonski approved these changes Dec 4, 2024

View reviewed changes

emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Dec 4, 2024

ludtkemorgan merged commit 0e3d9c8 into main Dec 4, 2024
20 checks passed

ludtkemorgan deleted the 4432/hometype branch December 4, 2024 14:58

ludtkemorgan mentioned this pull request Jan 15, 2025

fix: add home type feature to backend and partners (#4484) housingbayarea/bloom#830

Merged

9 tasks

ludtkemorgan mentioned this pull request Jan 21, 2025

Release: 2025-01-21 metrotranscom/doorway#1055

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add home type feature to backend and partners #4484

fix: add home type feature to backend and partners #4484

ludtkemorgan commented Nov 20, 2024 •

edited

Loading

netlify bot commented Nov 20, 2024 •

edited

Loading

netlify bot commented Nov 20, 2024 •

edited

Loading

accesslint bot left a comment

accesslint bot left a comment

YazeedLoonat left a comment

emilyjablonski left a comment •

edited

Loading

accesslint bot left a comment

ludtkemorgan commented Dec 3, 2024

emilyjablonski left a comment

ludtkemorgan commented Dec 4, 2024

fix: add home type feature to backend and partners #4484

fix: add home type feature to backend and partners #4484

Conversation

ludtkemorgan commented Nov 20, 2024 • edited Loading

Description

How Can This Be Tested/Reviewed?

Author Checklist:

Review Process:

netlify bot commented Nov 20, 2024 • edited Loading

✅ Deploy Preview for partners-bloom-dev ready!

netlify bot commented Nov 20, 2024 • edited Loading

✅ Deploy Preview for bloom-exygy-dev ready!

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

YazeedLoonat left a comment

Choose a reason for hiding this comment

emilyjablonski left a comment • edited Loading

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

ludtkemorgan commented Dec 3, 2024

emilyjablonski left a comment

Choose a reason for hiding this comment

ludtkemorgan commented Dec 4, 2024

ludtkemorgan commented Nov 20, 2024 •

edited

Loading

netlify bot commented Nov 20, 2024 •

edited

Loading

netlify bot commented Nov 20, 2024 •

edited

Loading

emilyjablonski left a comment •

edited

Loading