Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling misused rte in evbuffer #5002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riverszhang89
Copy link
Contributor

If we see an "rte", write a response and wait for the next "newsql".

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/596 tests failed ⚠.

The first 10 failing tests are:
incremental_backup_load
cldeadlock

@riverszhang89 riverszhang89 force-pushed the noop_rte branch 2 times, most recently from abafc17 to 7fa72c2 Compare February 5, 2025 14:54
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/596 tests failed ⚠.

The first 10 failing tests are:
osql_cleanup
reco-ddlk-sql
incremental_backup_load

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/597 tests failed ⚠.

The first 10 failing tests are:
sc_transactional_rowlocks_generated
incremental_backup_load

If we see an "rte", write a response and wait for the next "newsql".

Signed-off-by: Rivers Zhang <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/597 tests failed ⚠.

The first 10 failing tests are:
phys_rep_tiered
sc_timepart_multiddl_generated
phys_rep_tiered_nosource_generated
phys_rep_tiered_firstfile_generated
incremental_backup_load
reco-ddlk-sql
cldeadlock

@riverszhang89
Copy link
Contributor Author

cdb2test Feb 6 12:14:51 2025 success noop_rte.R20250206.4

@akshatsikarwar
Copy link
Contributor

Requested to log pid, argv0 in addition to hostname.

@riverszhang89
Copy link
Contributor Author

When querying comdb2db, no client info is sent. The host name is all we have. I was hoping that there'd be a short list of hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants