-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Benchmarks #165
Open
ms2892
wants to merge
9
commits into
bloomberg:main
Choose a base branch
from
ms2892:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding Benchmarks #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 48 48
Lines 5524 5524
Branches 873 873
=======================================
Hits 4961 4961
Misses 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
See changelog for more details. Signed-off-by: Pablo Galindo <[email protected]> Signed-off-by: ms2892 <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: ms2892 <[email protected]>
Both need to be updated at once, and also the uploaded artifacts now must be each be named something different and are made immutable. This means that we cannot keep appending to the same archive called "artifact", and that we instead must create one artifact for the sdist and one for each architecture. Note that the `upload_pypi` step also needs to be changed to ensure it downloads all of the artifacts and extracts them as before. Signed-off-by: Gus Monod <[email protected]> Signed-off-by: ms2892 <[email protected]>
Signed-off-by: Matt Wozniski <[email protected]> Signed-off-by: ms2892 <[email protected]>
Signed-off-by: Matt Wozniski <[email protected]> Signed-off-by: ms2892 <[email protected]>
Signed-off-by: ms2892 <[email protected]>
Signed-off-by: ms2892 <[email protected]>
Signed-off-by: ms2892 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61 (comment)
Added Benchmarks
This pull request introduces the Benchmarks using airspeed velocity - (asv)
Testing performed
Locally ran the following commands