Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use event sender as DCO signoff #38

Closed
wants to merge 1 commit into from
Closed

Conversation

molisani
Copy link
Member

@molisani molisani commented Nov 4, 2024

Describe your changes
The release workflow as it currently exists fails because the github-actions[bot] account attempts to push and it get blocked by the DCO requirement. The nx release command doesn't allow us to customize the body of the commit, but we can use a git hook to append the DCO suffix to the end of the body. The name/email are derived from the sender object, which reflects the github user that triggered the action.

Signed-off-by: Michael Molisani <[email protected]>
@molisani molisani self-assigned this Nov 4, 2024
@molisani molisani requested a review from a team as a code owner November 4, 2024 14:39
@github-actions github-actions bot added the ci 🤖 Relates to CI or GitHub Actions label Nov 4, 2024
@molisani
Copy link
Member Author

molisani commented Nov 4, 2024

Actually this will still fail because we cannot list github-actions[bot] as being exempt from the PR requirement in branch protection

@molisani molisani closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci 🤖 Relates to CI or GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant