Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for XcodeProj with strongly typed settings #145

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kwridan
Copy link
Contributor

@kwridan kwridan commented Feb 19, 2025

Describe your changes

Test Plan

  • Verify CI passes

- Updates to xcdiff for compatibility with tuist/XcodeProj#903
- Build setting values are no longer type erased and instead can now either be a `String` or `[String]`
- This alleviates the need to casting values and throwing errors when dealing with build settings

Test Plan:

- Verify CI passes

Signed-off-by: Kassem Wridan <[email protected]>
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 88.13559% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.09%. Comparing base (c48fb45) to head (1b2ac14).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ffCore/Comparator/ResolvedSettingsComparator.swift 64.70% 6 Missing ⚠️
Sources/XCDiffCore/Library/PBX+Extensions.swift 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   97.05%   97.09%   +0.04%     
==========================================
  Files          52       53       +1     
  Lines        2986     3034      +48     
==========================================
+ Hits         2898     2946      +48     
  Misses         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant