-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pre commit #66
Conversation
* add pre-commit for ruff * add pre commit * add precommit github workflow * update pre-commit version * add pre-commit task * run pre-commit * enable more pre-commit checks * remove black * update pixi.lock * add typo * add precommit to docker * remove black settings * extract ruff settings into ruff.toml * extract ruff settings into ruff.toml * update pre-commit hooks
* add more precommit * fix spelling * pre-commit all
Reviewer's Guide by SourceryThis PR introduces pre-commit hooks and transitions from Black to Ruff for code formatting. The changes include setting up pre-commit configuration, updating the project's dependencies, and modifying various CI-related files. The formatting configuration has been moved from pyproject.toml to dedicated configuration files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blooop - I've reviewed your changes - here's some feedback:
Overall Comments:
- This PR contains several unrelated changes (bash completion removal, file endings, CI token changes). Please split these into separate PRs to keep this one focused on just the pre-commit hooks and formatter changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Integrate pre-commit hooks into the project to automate code quality checks and formatting. Replace Black with Ruff for formatting tasks and add a new GitHub Actions workflow to run pre-commit checks on pull requests. Fix a typo in the README.md file.
New Features:
Enhancements:
CI:
Documentation: