Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a Nushell script for 'files' module #382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmpinder
Copy link
Member

@gmpinder gmpinder commented Jan 18, 2025

So from testing out errors, I've found that putting bool checks into a variable makes it so that we can take the span of the bool variable so that when we run into an error, we can supply that span to the error. This makes it easier for users to see how the check is happening.

Example of one of the error messages:

image

@gmpinder gmpinder self-assigned this Jan 18, 2025
@gmpinder gmpinder force-pushed the nushell/files branch 14 times, most recently from eae8233 to 26467d3 Compare January 19, 2025 00:59
@xynydev
Copy link
Member

xynydev commented Jan 19, 2025

Nice! Are we planning to write all modules in Nushell going forward? Should probably discuss.

If and since the files@v1 and files@v2 introduced in this PR use the exact same syntax and support the same featureset, what is the reason for keeping the bash version around?

@gmpinder
Copy link
Member Author

Nice! Are we planning to write all modules in Nushell going forward? Should probably discuss.

If and since the files@v1 and files@v2 introduced in this PR use the exact same syntax and support the same featureset, what is the reason for keeping the bash version around?

I figured I'd version it mostly cause I wanted to drop the old schema in favor of only the source and destination schema.

@gmpinder gmpinder marked this pull request as ready for review January 19, 2025 16:40
@xynydev
Copy link
Member

xynydev commented Jan 19, 2025

I figured I'd version it mostly cause I wanted to drop the old schema in favor of only the source and destination schema.

Oh yeah, I didn't notice that. Sounds good. That means we have to announce this change, so we better bundle it with #336. Also, versioned modules need separate README's for each version. Feel free to look at what's happening with the default-flatpaks PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants