feat: Added user/firewall endpoint and Tests #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add BGP neighbour path and best path count
* Add probe selection capability from configuration file * Add probe prefix matching + documentation * fix typo in README.md Co-authored-by: Christian Svensson <[email protected]> * fix typo in README.md Co-authored-by: Christian Svensson <[email protected]> * fix-fmt internal/config/main.go Co-authored-by: Christian Svensson <[email protected]>
* refactor(config): Add re-init function for testing This will allow tests to re-initialize the config structure to apply any calls to e.g. flag.Set() that may have happened. * Fix typo
* rebase: Add probe for vpn SSL users * probe VPN/Ssl: patch test file for handeling cli option + fix probe logic to always provide fortigate_vpn_connections * probe VPN/Ssl: default max-vpn-users to 0 + doc
* Add probe for vpn SSL stats * Add specification on SSL VPN metric description Co-authored-by: Christian Svensson <[email protected]> * vpn_ssl_stats_test.go Error message fix Co-authored-by: Christian Svensson <[email protected]> * probe vpn_ssl_stats: fix test output + metric description * VPN/Ssl probe name specified to VPN/Ssl/Connections to allow include/exclude without collision with VPN/Ssl/Stats * probe vpn_ssl_stats: remove current from metric name Co-authored-by: Christian Svensson <[email protected]>
Boolean flags behave a bit differently.
… queue (#121) Co-authored-by: Sebastian Poxhofer <[email protected]> Co-authored-by: Christian Svensson <[email protected]>
…f mutliple connections Co-authored-by: Sebastian Poxhofer <[email protected]>
* Add probe for Fsso Infos * fix user-fsso example file comment * probe User/Fsso: add support and example for fsso-polling mode * probe User/Fsso: add id label to follow fsso-polling naming and not merge it with fsso name label
Add a chat room for discussions
…file configuration (#139) * doc(readme): detail permissions per probe + update global monitor profile configuration * move monitor profile configuration bloc description
* feat(probe): Add probe for fortigate internal clock time * add seconds to mectric name + fix typo Co-authored-by: Christian Svensson <[email protected]> * Change category name to System/Time/Clock * add probe to permission table Co-authored-by: Christian Svensson <[email protected]>
* ci(Makefile): add coverage report and run additional tests * ci(Makefile): remove snapshot update from Makefile
…imestamp accuracy (#144)
* feat(probe): Add probe for sensors * add probe to permission table * switch log prefix from error to warning because probe will fail on small fortigate units
…tatus (#133) * Add probe for Fortimanager connection and registration status * probe System/Fortimanager/status: add support for mutiVDOM, merge 2 status metrics in 1 info metric, fix indentation issue * probe System/Fortimanager/status: fix metrics name in documentation * probe System/Fortimanager/status: split into 2 status metrics with value meaning + fix doc
Apparently pagination does not work on newer FortiOS on this particular API call. It seems unlikely that somebody with more than 1000 APs would complain about large API calls, so remove the limit for now.
* feat(probe): Add system reboot and snapshot time * Apply suggestions from code review Co-authored-by: Sebastian Poxhofer <[email protected]>
….0 (#198) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: Add support for managed switches * fix: update to go 1.18
* feat: Add support for managed switches * feat: Add dynamic configuration * fix: update to go 1.18 * doc(readme): enforce text about protecting the api tokens in Prometheus
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update README.md --------- Co-authored-by: Faizan Syed <[email protected]> Co-authored-by: Christian Svensson <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….0 (#212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Target our own documentation for PR issues
* Adding functionality for querying the status of SDN Connectors
* fix(BGP Info): Added support for bgp session state as value next to label * test(bgp): Updated tests to account for new value * test(bgp): Also change metric description in tests --------- Co-authored-by: Gianni Stubbe <[email protected]>
* docs: Updated descriptions of metrics to be self-explanatory * test(interface): Fixed tests for system and ipsec interfaces --------- Co-authored-by: Gianni Stubbe <[email protected]>
* feat(ippool): Added support for ippool info This merge adds support for ippool information. This closes #231 * fix(naming): Updated metric names to be in line with prometheus conventions * test(ippool): Added tests for the firewall ippool feature * style: Updated tests and readme to align for new naming * style: Changed metric name to match other percentage metrics * fix(ippool): Updated value percentage to be 0-1.0 --------- Co-authored-by: Gianni Stubbe <[email protected]>
Co-authored-by: Joel Norberg <[email protected]>
….0 (#250) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Christian Svensson <[email protected]>
jahknem
changed the title
|
There was a security issue. I'll create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files that have been added:
./pkg/probe/user_firewall.go
./pkg/probe/user_firewall_test.go
./pkg/probe/testdata/user_firewall.jsonnet
Files that have been changed:
./pkg/probe/probe.go
./README.md
Tested on FortiGate with FortiOS Version v7.0.12