feat: Added pba_per_ip return for ippool to differentiate between ippool types #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add it to the README as well? Thanks! |
bluecmd
approved these changes
Jan 4, 2024
done! |
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
a while ago I added the ippool probe to the exporter. While using this we noticed that it is hard to see if an ip pool is exhausted if you are mix and matching one-to-one and pba ip pools.
Unfortunately the api does not return the ippool type but it does return the amount of pba_per_ip which is 1 for a one-to-one and x for port-block-allocation. This way we can kind of differentiate the types being in use and we can create reasonable alerts:
fortigate_ippool_available_ratio < 0.2 and fortigate_ippool_pba_per_ip != 1Also it seems like overload ippools are not being returned by the API (which I have just noticed now).