test: Attempt to fix flaky tests for Windows & Android #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How debugging this feels like: |
|
Hmm seems like windows does not support IntegrationTestPlugin with captureScreenshot: https://github.com/flutter/flutter/blob/master/packages/integration_test/integration_test_macos/pubspec.yaml |
|
This only happens if GH is on its limits and takes longer than expected for some tasks... 😪 Very flaky, but hope to fix it some day. |
Gustl22
changed the title
|
Maybe due to: actions/runner-images#7320 |
Gustl22
changed the title
# Conflicts: # packages/audioplayers/example/integration_test/lib_test.dart
Gustl22
changed the title
# Conflicts: # .github/workflows/test.yml # packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart # packages/audioplayers/example/integration_test/app_test.dart
…/bluefireteam/audioplayers into gustl22/increase-timeout-windows
Gustl22
changed the title
spydon
approved these changes
Sep 7, 2023
|
Still not fixed according to https://github.com/bluefireteam/audioplayers/actions/runs/6110536581/job/16584118505 |
Gustl22
added a commit
that referenced
this pull request
Sep 26, 2023
# Description The tests in Windows & Android are possibly flaky for this reason: - In general it is not tested, if a source starts to play for app tests. - In the app test for `ReleaseMode.loop`, the source starts to play, but never completes or stops. See: https://github.com/bluefireteam/audioplayers/blob/fe81f3b1e600fe005febbe7cd3da02735a3de004/packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart#L104 . This is now checked by getting the current position. The solution to the problem also raises another issue on Android, as the position can not be retrieved on very short sources, thus they are excluded from these tests and it is expected to make it work with Exoplayer (#1526). (cherry picked from commit c5b0b6e)
Gustl22
added a commit
that referenced
this pull request
Nov 14, 2023
# Description The tests in Windows & Android are possibly flaky for this reason: - In general it is not tested, if a source starts to play for app tests. - In the app test for `ReleaseMode.loop`, the source starts to play, but never completes or stops. See: https://github.com/bluefireteam/audioplayers/blob/fe81f3b1e600fe005febbe7cd3da02735a3de004/packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart#L104 . This is now checked by getting the current position. The solution to the problem also raises another issue on Android, as the position can not be retrieved on very short sources, thus they are excluded from these tests and it is expected to make it work with Exoplayer (#1526).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests in Windows & Android are possibly flaky for this reason:
ReleaseMode.loop, the source starts to play, but never completes or stops. See:audioplayers/packages/audioplayers/example/integration_test/app/tabs/controls_tab.dart
Line 104 in fe81f3b
The solution to the problem also raises another issue on Android, as the position can not be retrieved on very short sources, thus they are excluded from these tests and it is expected to make it work with Exoplayer (#1526).
Sometimes CI fails, cause Windows needs a long time to finish playing a source with lengths< 2s.See: https://github.com/bluefireteam/audioplayers/actions/runs/4455910532/jobs/7826010863
This increases the timeout, so
onCompleteshould be called in that time slot.audioplayers/packages/audioplayers/test/audioplayers_test.dart
Line 125 in 8babb0e
Checklist
fix:,feat:,docs:,chore:etc).///, where necessary.Breaking Change
Related Issues
https://github.com/bluefireteam/audioplayers/actions/workflows/test.yml?query=branch%3Agustl22%2Fincrease-timeout-windows