Adds code standard checking #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds .editorconfig to make things consistent - Adds .phpcs.dist.xml and .php-cs-fixers.dist.php for PHP linting - Adds jsconfig.json to allow IDE eslint to correctly associate aliases - Updates Composer and NPM commands to include linting
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
feature/code-standards-2
|
| Run status |
|
| Run duration | 36m 45s |
| Commit |
|
| Committer | Brad Parbs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
416
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
vendor/newfold-labs/wp-module-migration/tests/cypress/integration/Migration/landIntoMigrationFromAM.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Verify Migration- emulating AM flow > Verify Migration page is loaded |
Test Replay
Screenshots
Video
|
|
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
feature/code-standards-2
|
| Run status |
|
| Run duration | 31m 18s |
| Commit |
|
| Committer | Brad Parbs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
1
|
|
Flaky
|
0
|
|
Pending
|
36
|
|
Skipped
|
0
|
|
Passing
|
416
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
vendor/newfold-labs/wp-module-migration/tests/cypress/integration/Migration/landIntoMigrationFromAM.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Verify Migration- emulating AM flow > Verify Migration page is loaded |
Test Replay
Screenshots
Video
|
|
|
Checks failing are to be expected until #852 is merged into this branch. |
4 tasks
|
Based on the lack of updates on this and the now number of conflicts, I think we can close this and reopen or restart if we have the need in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #851
This adds the files and configurations for code standards and linting. Another PR based off this branch will include the first round of fixes for it.
Adds .editorconfig to make things consistent
Adds .phpcs.dist.xml and .php-cs-fixers.dist.php for PHP linting
Adds jsconfig.json to allow IDE eslint to correctly associate aliases
Updates Composer and NPM commands to include linting