Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Facebook Connect in Settings Page #1020

Merged
merged 33 commits into from
May 20, 2024
Merged

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Apr 5, 2024

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Created this for: #1019 so that tests run.

Copy link

cypress bot commented Apr 5, 2024

1 flaky test on run #8398 ↗︎

0 392 50 0 Flakiness 1

Details:

update lock files
Project: Bluehost Brand Plugin Commit: a5e11b949e
Status: Passed Duration: 25:11 💡
Started: May 20, 2024 5:33 AM Ended: May 20, 2024 5:58 AM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1020 ↗︎

@wpscholar
Copy link
Member

@arunshenoy99 Can you give this PR a refresh?

@ramyakrishnai ramyakrishnai requested a review from wpscholar April 18, 2024 14:44
Copy link

cypress bot commented Apr 18, 2024

1 failed test on run #8086 ↗︎

1 403 29 0 Flakiness 0

Details:

Merge b06fd38 into 4432dd6...
Project: Bluehost Brand Plugin Commit: 5d444eac6c ℹ️
Status: Failed Duration: 21:56 💡
Started: Apr 18, 2024 2:47 PM Ended: Apr 18, 2024 3:09 PM
Failed  tests/cypress/integration/settings.cy.js • 1 failed test

View Output Video

Test Artifacts
Settings Page > Has Auto Updates Settings Test Replay Screenshots Video

Review all test suite changes for PR #1020 ↗︎

src/app/pages/settings/socialMediaAccounts.js Outdated Show resolved Hide resolved
src/app/pages/settings/socialMediaAccounts.js Outdated Show resolved Hide resolved
src/app/pages/settings/socialMediaAccounts.js Outdated Show resolved Hide resolved
@ramyakrishnai ramyakrishnai requested a review from wpscholar May 7, 2024 05:52
@wpscholar
Copy link
Member

@ramyakrishnai The changes look good. Let's resolve the issue with the composer.lock file and fix the linting errors.

@ramyakrishnai
Copy link
Contributor

@ramyakrishnai The changes look good. Let's resolve the issue with the composer.lock file and fix the linting errors.

Updated @wpscholar

@wpscholar
Copy link
Member

@arunshenoy99 / @ramyakrishnai / @manikantakailasa - Shouldn't this file live in the Facebook module? src/app/pages/settings/socialMediaAccounts.js

@manikantakailasa
Copy link
Contributor

@arunshenoy99 / @ramyakrishnai / @manikantakailasa - Shouldn't this file live in the Facebook module? src/app/pages/settings/socialMediaAccounts.js

The Facebook module will only provide access to or receive data from Facebook. According to the plans, we may have more social media connections in the future, including Instagram. so this file will help to connect to different social media modules.

@wpscholar
Copy link
Member

@manikantakailasa Please update to address conflicts. Thanks!

@ramyakrishnai ramyakrishnai requested a review from wpscholar May 16, 2024 11:49
@wpscholar
Copy link
Member

@ramyakrishnai It appears this still has a conflict

@wpscholar wpscholar merged commit fc10f28 into develop May 20, 2024
3 checks passed
@wpscholar wpscholar deleted the add/facebook-module branch May 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants