Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/Launchpad with view & add buttons - PRESS4 509 #1040

Merged
merged 21 commits into from
Apr 22, 2024

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Apr 18, 2024

Proposed changes

We will have a pages menu item
And there will be launchpads for each public content type
And there will be lanchpads for each public custom content type
And there will be a "view all" option for each type
And there will be an "add new" option for each type.

story - https://jira.newfold.com/browse/PRESS4-509

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Created this for: #1023 so that tests run.

Copy link

cypress bot commented Apr 18, 2024

1 flaky test on run #8087 ↗︎

0 409 29 0 Flakiness 1

Details:

Merge a5bbed6 into 4432dd6...
Project: Bluehost Brand Plugin Commit: 89c6bab9cb ℹ️
Status: Passed Duration: 22:13 💡
Started: Apr 18, 2024 2:52 PM Ended: Apr 18, 2024 3:14 PM
Flakiness  vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/top-priority.cy.js • 1 flaky test

View Output Video

Test Artifacts
Top Priority Page > Check for API events when different cards are selected Test Replay Screenshots Video

Review all test suite changes for PR #1040 ↗︎

@wpscholar
Copy link
Member

Posting previous feedback from @wpalani in order to preserve context here:

Thanks, @manikantakailasa, for opening this PR. Here are some items I noticed while reviewing the code/UI:

  • There appears to be an extra border or shadow around some of the UI boxes that are throwing off the UI.
    ext-border
  • UI needs a mobile breakpoint similar to other pages in the app. Please look at other pages/components to see how the responsiveness is handled.
  • Products box needs to check if WooCommerce is active before displaying it. Now, the links on it go to an invalid post type page when clicked on while WooCommerce is not present.
  • Booking and Appointments box needs to check if WooCommerce is active in addition to the Yith plugin before displaying it. Now, the links on it go to an invalid post type page when clicked on while WooCommerce is not present.
  • pagesAndPosts/index.js has /* eslint-disable prettier/prettier */ comment on top which disables eslint/prettier this needs to be removed and the component needs to be linted properly.
  • Reslove outstanding merge conflicts.
  • Please write Cypress tests for the new page/UI.
  • Less important: the root package.json file spacing appears to be changed from tabs/4 to spaces/2. Please fix for consistency.

@wpscholar
Copy link
Member

@ramyakrishnai It looks like tests didn't run with the last commit. Any ideas why?

@wpscholar
Copy link
Member

@wpalani Would you be able to do another review to see if your concerns were addressed?

@ramyakrishnai
Copy link
Contributor Author

@ramyakrishnai It looks like tests didn't run with the last commit. Any ideas why?

@wpscholar I'm unsure why it didn't occur the previous time, but after editing it, it began.

@wpalani wpalani changed the base branch from develop to add/launchpad April 22, 2024 02:53
@wpalani wpalani merged commit 24ad9da into add/launchpad Apr 22, 2024
1 check failed
@wpalani wpalani mentioned this pull request Apr 22, 2024
8 tasks
@wpalani wpalani deleted the PRESS4-509 branch July 18, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants