Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onboarding to 2.3.2 #1089

Merged
merged 2 commits into from
May 29, 2024
Merged

Update Onboarding to 2.3.2 #1089

merged 2 commits into from
May 29, 2024

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented May 28, 2024

Proposed changes

1. Limit the number of times a user can click on "Try Again"

image

2. Change the AI Sitegen flow's dark/light theme based on the desktop preference

image

3. Remove the minimum character limit in the AI Sitegen flow's site details prompt

image

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented May 28, 2024

1 flaky test on run #8416 ↗︎

0 393 49 0 Flakiness 1

Details:

Update lock file
Project: Bluehost Brand Plugin Commit: c3e5de3899
Status: Passed Duration: 23:44 💡
Started: May 28, 2024 9:29 AM Ended: May 28, 2024 9:52 AM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1089 ↗︎

Copy link

cypress bot commented May 28, 2024

30 failed and 1 flaky tests on run #8415 ↗︎

30 356 47 9 Flakiness 1

Details:

Merge 26c7241 into 0d61b82...
Project: Bluehost Brand Plugin Commit: c78d2e23d5 ℹ️
Status: Failed Duration: 37:51 💡
Started: May 28, 2024 7:31 AM Ended: May 28, 2024 8:09 AM
Failed  2-welcome.cy.js • 9 failed tests

View Output Video

Test Artifacts
SiteGen Welcome Step > Check for the header admin bar Test Replay Screenshots Video
SiteGen Welcome Step > Check for the existing dark background Test Replay Screenshots Video
SiteGen Welcome Step > Check for the light background Test Replay Screenshots Video
SiteGen Welcome Step > Check the Progress Bar Value Test Replay Screenshots Video
SiteGen Welcome Step > Check for back button and go back Test Replay Screenshots Video
SiteGen Welcome Step > Check if the orb is visible Test Replay Screenshots Video
SiteGen Welcome Step > Check for the heading title Test Replay Screenshots Video
SiteGen Welcome Step > Check for the subheading title Test Replay Screenshots Video
SiteGen Welcome Step > Check the Get Started button Test Replay Screenshots Video
Failed  3-site-details.cy.js • 9 failed tests

View Output Video

Test Artifacts
SiteGen Site Details Step > Check for the header admin bar Test Replay Screenshots Video
SiteGen Site Details Step > Check for the existing dark background Test Replay Screenshots Video
SiteGen Site Details Step > Check for the light background Test Replay Screenshots Video
SiteGen Site Details Step > Check the Progress Bar Value Test Replay Screenshots Video
SiteGen Site Details Step > Check if the Next Button is disabled when no prompt is entered Test Replay Screenshots Video
SiteGen Site Details Step > Check for the header to be visible Test Replay Screenshots Video
SiteGen Site Details Step > Check for the placeholder text & input box hint to be visible before the prompt Test Replay Screenshots Video
SiteGen Site Details Step > Enter the prompt and see the box-info progress Test Replay Screenshots Video
SiteGen Site Details Step > Check if the Next Button is enabled and click Next Test Replay Screenshots Video
Failed  4-site-logo.cy.js • 1 failed test

View Output Video

Test Artifacts
SiteGen Site Logo Step > Check for the header admin bar Test Replay Screenshots Video
Failed  5-experience.cy.js • 6 failed tests

View Output Video

Test Artifacts
SiteGen Experience & Site Building Step > Check for the header admin bar Test Replay Screenshots Video
SiteGen Experience & Site Building Step > Check for the existing dark background Test Replay Screenshots Video
SiteGen Experience & Site Building Step > Check for the light background Test Replay Screenshots Video
SiteGen Experience & Site Building Step > Check the Progress Bar Value Test Replay Screenshots Video
SiteGen Experience & Site Building Step > Check for the existence & the count of experience level cards Test Replay Screenshots Video
SiteGen Experience & Site Building Step > Check each experience cards Test Replay Screenshots Video
Failed  6-preview.cy.js • 5 failed tests

View Output Video

Test Artifacts
SiteGen Site Preview Step > Check for the header admin bar Test Replay Screenshots Video
SiteGen Site Preview Step > Check for the existing dark background Test Replay Screenshots Video
SiteGen Site Preview Step > Check for the light background Test Replay Screenshots Video
SiteGen Site Preview Step > Check the Progress Bar Value Test Replay Screenshots Video
SiteGen Site Preview Step > Check for by default 3 versions should be there Test Replay Screenshots Video
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1089 ↗︎

@circlecube
Copy link
Member

@arunshenoy99 - have you all taken a look at the failing tests yet?

@arunshenoy99
Copy link
Member Author

@arunshenoy99 - have you all taken a look at the failing tests yet?

@circlecube We did. The latest commit does not have failing tests. Not sure why the bot did not add a comment, though. Thanks!

@circlecube circlecube merged commit 63db968 into develop May 29, 2024
3 checks passed
@officiallygod officiallygod deleted the update/onboarding branch June 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants