-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Onboarding to 2.3.4 #1111
Merged
Merged
Bump Onboarding to 2.3.4 #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 failed and 1 flaky tests on run #8735 ↗︎
Details:
Site-Capabilities/siteCapabilities.cy.js • 1 failed test
Store/storePage.cy.js • 1 failed test
vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test
Review all test suite changes for PR #1111 ↗︎ |
@circlecube This is the latest release of onboarding that is supposed to go with the plugin, Please take a look whenever you get time, Thanks. The Failing tests are due to ecom module, Please let me know if there are any other concerns. |
circlecube
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Type of Change
Checklist
Release Notes
https://github.com/newfold-labs/wp-module-onboarding/releases/tag/2.3.3